For the newest piefed release, I worked on a new feature, that allows community admins to choose a “community theme”, which overrides the users theme while they are browsing the specific community. This works for every user on piefed, that has the newest version, it unfortunately won’t show up on lemmy, because they have a completely different theming system.
There are already some cool themes to choose from (the themes, that the users could pick from before), but the idea with this, is that you can create your own themes for your community and propose it to our Codeberg repository. There are so many cool ways, to make your community stand out, I am imagining maybe a swirling background for a balatro community, a theme that makes posts looked like ripped out pages and a custom comic-book hand as a cursor for !nonpolitical_comics@piefed.social or other comic communities, maybe the hercules, or irix theme for retro communities.
I am sure you have many ideas, that are even cooler and I really hope that piefed get’s even more wild and interresting with this update!
(PS: I know that the screenshot is of a lemmy community and that this wouldn’t work, it’s just meant as an example)
Cool,
but for anybody wondering like me if you can disable it.
Yup, there is an option for it.
I could imagine wanting to disable this on a per-community basis.
I really like the idea, but eventually some community I’d otherwise enjoy is bound to invent a personalized style that is, for reason or another, not good for mybuse andbI will then have to disable the feature for all communities :(
(As a workaround: will this be doable as additional CSS?)
That was my next question, thank you @DeckPacker@piefed.social for working on this!
Shame for the screenshot but very cool :D
A wiki page that help with theming would be great :)
There is a theming guide on our Codeberg, if you are interested: https://codeberg.org/rimu/pyfedi/src/branch/main/docs/developer_docs/09_Theming_Guide.md
Oh thank, wonderful…i have lot to catchup 😅
Mmm i will create a link to this page and a minimale wiki page. I would be also great to check out the wiki of fedican :)
This is awesome.
Is there a user option to override it and continue to use the users theme?
Also do themes have to be added to the codeberg? If an admin uploads it directly for their instances directory would that work, and would browsing that from a different instance load it or would they also need the theme in their files?
And, to your other question, there is an option in the user settings to disable community themes.
I remember Reddit had a little tick box for each community? There was a benefit to blocking some obnoxious ones but keeping good ones, might be something to look into for a future update.
Yeah, that’s a good idea, I’ll try to implement that in a future update.
To do this on a per-community basis, it might make sense to store it in the session cookie rather than in the db. Look for instances of
response.set_cookieandrequest.cookies.getto see other examples of where we do that.Some user settings are stored in the cookie to look at as an example; stuff like the compactness level, low bandwidth mode, etc. Basically anything that is set on a per-device basis rather than stored in the db.
Disabling a particularly annoying theme seems to me like something you would wanna do on every device, no?
Maybey it would make sense to store the user theme in a cookie though, because that is a thing, you may want to be different on different types of devices.
Do you know, how long such a cookie lasts?
My thinking on a per-device basis was that themes might work better/worse in a mobile vs. desktop browser, so people might prefer different experiences, but I could see the other side of things as well. That was also the rationale for making compact mode be in the cookie rather than saved in the db.
I honestly don’t know what the expiration of the session cookie is. It might depend on the browser. I think it is pretty long-lasting unless people clear their cache because I have definitely loaded up piefed instances after a long time and have still been logged in.
As for technical details, to save space, it might make sense to make a key (maybe like
ignore_comm_theme) be a comma-separated list of community id’s that people have unchecked the box. That means you can easily convert this to a list withsplitand then see if the currently requested community id isinthat list. Being the id means that it is unique for the instance and avoids name collisions like the actual community name might have (how manylinuxcommunities do we have now). It also keeps things relatively small since the cookie has a pretty small size limit iirc.
Yeah, unfortunately it will only work for servers, that have the theme in their files, so you would have to propose it to the repo.
This is mainly because of security concerns, because there are a lot of ways to inject malicious Javascript code into a theme, and we don’t want that federating across piefed.Any reason the themes can’t just be CSS and no JavaScript? This would prevent the risk.
There are a lot of ways to inject javascript into css aswell. With @import, if you just escape css with </style> and so many more. It would be a herculean task to really sanitize css so that it’s fully safe unfortunately and if we were to make any mistake, that would pose a massive security risk for our users.
So maybe it’s possible, but I am afraid, that it’s beyond the scope of our project.
That’s a fair enough reason. Shame it has to be that way, hope it doesn’t lead to bloat with hundreds/thousands of community themes.
Will look great on the Pip-Boy!
Great !
